689 update to Vert.x 4.0.3 #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
689-update-to-vert.x-4
branch
from
a0d9874 to
107dddb
Compare
Some errors only appear in the standard output
There is a bug in Vert.x client that causes some tests to fail with Db2. We need to re-enable these tests once the issue has been solved. See: eclipse-vertx/vertx-sql-client#920
DavideD
force-pushed
the
689-update-to-vert.x-4
branch
from
107dddb to
4340169
Compare
DavideD
force-pushed
the
689-update-to-vert.x-4
branch
3 times, most recently
from
25863b3 to
60b2e54
Compare
Solve an AssertionError on the ouput stream when running all the tests on CI
DavideD
force-pushed
the
689-update-to-vert.x-4
branch
from
60b2e54 to
c49f51b
Compare
It fails on CI but not locally
DavideD
force-pushed
the
689-update-to-vert.x-4
branch
from
71c7436 to
d594cd8
Compare
|
I think we can merge this changes now. |
|
Merged #694 |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689
I've updated to Vert.x but I had to disable some tests on Db2 because of eclipse-vertx/vertx-sql-client#920
I will create an issue so that we don't forget to re-enable them when we will upgrade to Vert.x 4.1